Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retry Policy wrapper for WF #658

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

DeepanshuA
Copy link
Contributor

@DeepanshuA DeepanshuA commented Jan 11, 2024

Description

Adds retry policy support via Dapr python sdk

Issue reference

Please reference the issue this PR will close: #576 and #660

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (2c328d1) 86.54% compared to head (3b095cb) 86.21%.

Files Patch % Lines
...apr-ext-workflow/dapr/ext/workflow/retry_policy.py 55.26% 17 Missing ⚠️
...orkflow/dapr/ext/workflow/dapr_workflow_context.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   86.54%   86.21%   -0.33%     
==========================================
  Files          78       79       +1     
  Lines        3953     3998      +45     
==========================================
+ Hits         3421     3447      +26     
- Misses        532      551      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA DeepanshuA marked this pull request as ready for review January 11, 2024 20:18
@DeepanshuA DeepanshuA requested review from a team as code owners January 11, 2024 20:18
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA
Copy link
Contributor Author

Was first thinking to create a separate PR for #660 but then thought that it will cause merge conflicts as well in this PR. So, included that in this PR itself.

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berndverst berndverst merged commit 593eb07 into dapr:main Jan 17, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workflow] Add SDK support for workflow retry policies
4 participants