Cascade terminate purge #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamkm07
force-pushed
the
cascade_terminatePurge
branch
from
821bd52
to
51f027f
Compare
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
shivamkm07
force-pushed
the
cascade_terminatePurge
branch
from
328a10c
to
8264b41
Compare
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 79 79
Lines 3998 3998
=======================================
Hits 3447 3447
Misses 551 551 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
berndverst
reviewed
Jan 24, 2024
berndverst
reviewed
Jan 24, 2024
berndverst
reviewed
Jan 24, 2024
| @@ -88,6 +96,8 @@ jobs: | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: ${{ env.GOVER }} | |||
| env: | |||
| GOPATH: ${{ github.workspace }} | |||
There was a problem hiding this comment.
Yeah it was failing without it with error GoPath not set
berndverst
reviewed
Jan 24, 2024
| @@ -56,7 +56,15 @@ jobs: | |||
| echo "CHECKOUT_REF=${{ github.event.client_payload.pull_head_ref }}" >> $GITHUB_ENV | |||
| echo "DAPR_REF=master" >> $GITHUB_ENV | |||
| fi | |||
|
|
|||
| - name: Parse workflow dispatch payload | |||
There was a problem hiding this comment.
Ah you refactored it to here. That's fine - hope it works :)
berndverst
reviewed
Jan 24, 2024
| @@ -25,7 +25,7 @@ packages = find_namespace: | |||
| include_package_data = True | |||
| install_requires = | |||
| dapr-dev >= 1.11.0rc1.dev | |||
| durabletask >= 0.1.0 | |||
| durabletask >= 0.1.1a1 | |||
There was a problem hiding this comment.
You really shouldn't use alpha versions as dependencies in this SDK. Please use a proper versioning scheme on the durable task side :)
There was a problem hiding this comment.
Will update once a stable version is released
berndverst
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for cascade terminate/purge in dapr workflow.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #661
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: