Implement support for cryptography api #719
Conversation
Signed-off-by: KentHsu <chiahaohsu9@gmail.com>
Signed-off-by: KentHsu <chiahaohsu9@gmail.com>
Signed-off-by: KentHsu <chiahaohsu9@gmail.com>
KentHsu
changed the title
|
Thank you very much for the PR Kent, I'll try to get to it asap. |
There was a problem hiding this comment.
Awesome PR. Thanks @KentHsu
Can you run tox -e flake8 and tox -e ruff please?
The linter is failing at the moment.
That step runs tox -e flake8, tox -e type, tox -e mypy and tox -e ruff.
| # assert | ||
| self.assertEqual(req.__class__, api_v1.EncryptRequest) | ||
| self.assertEqual(req.payload.data, b'hello dapr') | ||
| self.assertEqual(req.payload.seq, 0) |
There was a problem hiding this comment.
Can we also test the rasing of StopIteration after the appropriate number of iterations, for larger (and empty) files? Same for the async version.
| EncryptDecryptFile(dapr) | ||
|
|
||
|
|
||
| def EncryptDecryptString(dapr: DaprClient): |
There was a problem hiding this comment.
A nit: let's rename to encrypt_decrypt_string and encrypt_decrypt_file, to follow the PEP 8 style guide.
| == APP == Running encrypt/decrypt operation on file | ||
| == APP == Wrote encrypted data to encrypted.out | ||
| == APP == Wrote decrypted data to decrypted.out.jpg | ||
| ``` |
There was a problem hiding this comment.
Please clean up the created resources in the end (the keys directory that was created and the .out files).
Description
Implement below in Dapr gRPC client
Implement below in Dapr gRPC aio client
Add cryptography examples follow go-sdk crypto example
Issue reference
Please reference the issue this PR will close: #548
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: