Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on macos validation in github actions #417

Merged
merged 6 commits into from
Nov 9, 2021

Conversation

wcs1only
Copy link
Contributor

@wcs1only wcs1only commented Apr 3, 2021

Description

This change adds MacOS to the CI/CD pipeline for quickstarts. We can no longer use the approach of executing all quickstarts in parallel, as this would cost us 14 machines from our worker pool. Instead, we use a Linux host and a Mac host and run the quickstarts serially. This comes at a cost of about 20 minutes of validation runs, but it saves us manually running quickstart validation on MacOS at release time.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary

@wcs1only wcs1only force-pushed the macos-quickstart-validation branch 4 times, most recently from b290090 to 2b71d4d Compare April 3, 2021 01:47
@wcs1only wcs1only force-pushed the macos-quickstart-validation branch 15 times, most recently from 47af3d1 to a99e1b3 Compare June 17, 2021 22:32
@wcs1only wcs1only force-pushed the macos-quickstart-validation branch from a99e1b3 to e37d13b Compare June 18, 2021 00:06
@wcs1only wcs1only force-pushed the macos-quickstart-validation branch from e37d13b to e048909 Compare July 16, 2021 16:51
@wcs1only wcs1only force-pushed the macos-quickstart-validation branch 5 times, most recently from e970189 to 8bd21ca Compare November 8, 2021 23:12
@wcs1only wcs1only marked this pull request as ready for review November 9, 2021 01:03
@wcs1only wcs1only merged commit 10e6c15 into dapr:master Nov 9, 2021
Arashrohani pushed a commit to Arashrohani/quickstarts that referenced this pull request Feb 16, 2022
* Turn on macos validation in github actions

* Matrix build on OS only

* Allow for some variance in orderid in bindings validation

* Add virtualbox

* Fix to macos 10.15

* Kafka install needs longer timeout on MacOS

Signed-off-by: Arash Rohani <arash.rohani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants