Adding 'dapr.io/sidecar-listen-addresses' annotation to middleware quickstart #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oapp deployment and note to readme
|
|
msfussell
reviewed
Oct 3, 2021
middleware/README.md
Outdated
| @@ -78,6 +78,8 @@ kubectl apply -f deploy/pipeline.yaml | |||
|
|
|||
| Next, you'll deploy the application and define an ingress rule that routes to the ```-dapr``` service that gets automatically created when you deploy your pod. In this case, all traffic is routed to the Dapr sidecar, which can reinforce various policies through middleware. | |||
|
|
|||
| >**Note:** 'dapr.io/sidecar-listen-addresses' annotation is added to echoapp deployment to allow external connections. Be cautious of using it in a Production environment. | |||
There was a problem hiding this comment.
Can you change "Production" to be lower case "production"
At the end of this new sentence can you add "To read more on this annotation see Dapr arguments and annotations for daprd, CLI, and Kubernetes
artursouza
approved these changes
Oct 6, 2021
msfussell
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on the issue I've raised in dapr repo to prevent users from encountering it. If a user will follow the middleware quickstart as it is right now - the issue will come up.
Added dapr.io/sidecar-listen-addresses annotation to echoapp deployment
Added note to readme to warn users about using this annotation in a Production environment.
Issue reference
This PR is based on the issue I've raised in dapr repo: dapr/dapr#3717
Please let me know if I need to create a separate issue in this repo and reference it.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: