Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hello-world example does not use DELETE. Removing dead code #494

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

wcs1only
Copy link
Contributor

Description

There's some dead and broken code in the hello-world example. Remove it for clarity.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #333

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary

@wcs1only wcs1only merged commit ecb79ef into dapr:master Dec 6, 2021
Arashrohani pushed a commit to Arashrohani/quickstarts that referenced this pull request Feb 16, 2022
…#494)

Signed-off-by: Arash Rohani <arash.rohani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect writing for delete state in hello-world nodeapp sample
2 participants