Fix upstream issue in Create-React-App #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
XavierGeerinck
force-pushed
the
patch-1
branch
from
ce5d28c
to
a6c0709
Compare
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
berndverst
approved these changes
Jan 18, 2022
Arashrohani
pushed a commit
to Arashrohani/quickstarts
that referenced
this pull request
Feb 16, 2022
* Fix upstream issue in Create-React-App Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Add distributed calculator fix for upstream plugin Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Editing wrong file Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Undo edits Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> * Make the build process a bit more clear Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> Signed-off-by: Arash Rohani <arash.rohani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug upstream in Create-React-App that doesn't initialize the MiniCssExtractPlugin correctly anymore as it is now requiring Types
Issue reference
Checklist