Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/java sdk pubsub quickstarts #533

Conversation

pravinpushkar
Copy link
Contributor

Description

Quickstart example for pubsub component using Dapr's Java SDK

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can take the Readme suggestion, it LGTM.

@msfussell this is the same review coming through again since the other wave of PRs got force merged, which closed this one.

pub_sub/java/sdk/README.md Outdated Show resolved Hide resolved
Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
@artursouza artursouza force-pushed the feature/java_sdk_pubsub_quickstarts branch from ef3fd03 to 60cb4b1 Compare February 15, 2022 22:11
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar force-pushed the feature/java_sdk_pubsub_quickstarts branch from 38a9392 to 9ad5f87 Compare February 16, 2022 06:20
@pravinpushkar
Copy link
Contributor Author

If you can take the Readme suggestion, it LGTM.

@msfussell this is the same review coming through again since the other wave of PRs got force merged, which closed this one.

README updated

@msfussell msfussell merged commit 85f6c6c into dapr:feature/new_quickstarts Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants