Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/java http pubsub quickstarts #534

Conversation

pravinpushkar
Copy link
Contributor

Description

Quickstart example for pubsub component using HTTP request

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the readme suggestion and then LGTM.

@msfussell this is a reissue of the PR we reviewed yesterday, after the force merge

pub_sub/java/http/README.md Outdated Show resolved Hide resolved
@pravinpushkar
Copy link
Contributor Author

Please take the readme suggestion and then LGTM.

@msfussell this is a reissue of the PR we reviewed yesterday, after the force merge

README updated

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar force-pushed the feature/java_http_pubsub_quickstarts branch from f3f8c2e to 2fe3633 Compare February 16, 2022 12:57
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell
Copy link
Member

@paulyuk @pravinpushkar Ok to merge?

@msfussell msfussell merged commit d4ffc33 into dapr:feature/new_quickstarts Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants