Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed loop from while to for #537

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Changed loop from while to for #537

merged 2 commits into from
Feb 17, 2022

Conversation

amulyavarote
Copy link
Contributor

@amulyavarote amulyavarote commented Feb 17, 2022

Signed-off-by: Amulya Varote amulyavarote@microsoft.com

Description

Changed a loop structure from "while" to "for"

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. This enables testing.

Could you please remove all 'imports random' Imports statements (and packages if that happened) if we're removing random?

While we're here should we just go ahead and update the same for ALL quickstarts (pubsub too) because it has effectively same code and same issue?

Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for updates.

@msfussell msfussell merged commit b34575e into dapr:feature/new_quickstarts Feb 17, 2022
@amulyavarote amulyavarote deleted the patch/change_looping branch February 17, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants