Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing GitHub actions for new quickstarts directory structure #538

Merged
merged 15 commits into from
Feb 22, 2022
Merged

Testing GitHub actions for new quickstarts directory structure #538

merged 15 commits into from
Feb 22, 2022

Conversation

amulyavarote
Copy link
Contributor

@amulyavarote amulyavarote commented Feb 17, 2022 •
edited

Description

Testing github actions

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

artursouza
artursouza requested changes Feb 18, 2022
View reviewed changes
.github/workflows/build.yml
@@ -8,15 +8,15 @@ name: samples
on:
push:
branches:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep master too.

.github/workflows/build.yml
- release-*
tags:
- v*
paths-ignore:
- '**.md'
pull_request:
branches:
- master
- feature/new_quickstarts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep master too.

.github/workflows/validate.yaml Outdated
@@ -8,13 +8,13 @@ name: Auto Validate Quickstarts
on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback for this workflow.

tutorials/observability/README.md Outdated
@@ -252,7 +252,7 @@ annotations:
...
```

For this quickstart, a configuration has already been enabled for every service in the distributed calculator app. You can find the annotation in each one of the calculator yaml files. For example review the yaml file for the calculator front end service [here](https://github.com/dapr/quickstarts/blob/master/distributed-calculator/deploy/react-calculator.yaml#L36).
For this quickstart, a configuration has already been enabled for every service in the distributed calculator app. You can find the annotation in each one of the calculator yaml files. For example review the yaml file for the calculator front end service [here](https://github.com/dapr/quickstarts/tree/feature/new_quickstarts/tutorials/distributed-calculator/deploy/react-calculator.yaml#L36).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this in master since we will not keep the new_quickstarts branch forever.

tutorials/observability/README.md Outdated
@@ -319,7 +319,7 @@ kubectl get pods

Then, open the distributed calculator UI.

If this is the first time trying the distributed calculator, find more detailed instructions in the [distributed-calculator](https://github.com/dapr/quickstarts/blob/master/distributed-calculator/README.md) quickstart.
If this is the first time trying the distributed calculator, find more detailed instructions in the [distributed-calculator](https://github.com/dapr/quickstarts/tree/feature/new_quickstarts/tutorials/distributed-calculator/README.md) quickstart.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep master

@amulyavarote
Modified github actions and the file paths
7cfbd5a 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Changed file paths in github actions
d01cdad 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Changed file paths in github actions in build yaml
6091c29 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Changed branch name for external link validation
ac52e71 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Added validation file
2b81562 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Modified paths for the validation to run
6ab0b0d 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Modified paths for the validation to run
f3b8781 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Fixed broken paths in all readmes
5704d2e 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Removed unnecessary files
c6e3146 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Added back removed files
64933fb 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Added missing files
5b69f6e 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Changes based on the review comments
5a15302 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Added removed files
503647b 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Changed branch name to test
3e6a2c4 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Added master back
8f3e8b7 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
paulyuk
paulyuk approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending Artur's changes

paulyuk
paulyuk reviewed Feb 19, 2022
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get Arturs suggestion in since this branch will go away later.

@paulyuk
Copy link
Contributor

paulyuk commented Feb 19, 2022

@artursouza lgtm now. you?

@artursouza artursouza merged commit 3ccd3d3 into dapr:feature/new_quickstarts Feb 22, 2022
@amulyavarote amulyavarote deleted the github_actions branch February 23, 2022 17:17
@amulyavarote amulyavarote mentioned this pull request Apr 12, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulyuk paulyuk paulyuk approved these changes

@artursouza artursouza artursouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amulyavarote @paulyuk @artursouza