-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for pubsub java #575
Add tests for pubsub java #575
Conversation
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
pub_sub/java/http/README.md
Outdated
|
||
2. Install dependencies: | ||
<!-- STEP | ||
name: Install Dotnet dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo error. It should be Java in place of Dot net.
pub_sub/java/http/README.md
Outdated
|
||
2. Run the Java publisher app with Dapr: | ||
<!-- STEP | ||
name: Run Dotnet publisher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo mistake
pub_sub/java/http/README.md
Outdated
|
||
2. Run the Java subscriber app with Dapr: | ||
<!-- STEP | ||
name: Run Dotnet publisher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here also
pub_sub/java/sdk/README.md
Outdated
|
||
2. Run the Java publisher app with Dapr: | ||
<!-- STEP | ||
name: Run Dotnet publisher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
@tanvigour Sorry for late review. There are few typo mistakes that needs attention. I have highlighted few but there are more occurrences of the same. |
Thanks Pravin! Addressed your feedback |
Description
Added tests for java http and sdk pubsub
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #551
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: