Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put reader in 'node' dir #595

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Put reader in 'node' dir #595

merged 1 commit into from
Mar 24, 2022

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Mar 11, 2022

W/o this change the reader might not realize they need to cd into the
'node' dir to see the app.js file that we talk about next.

Also removed some extra whitespace at the end of some lines.

Wasn't sure which branch to base this off of, let me know if you want it moved.

Signed-off-by: Doug Davis dug@microsoft.com

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @duglin for the contributions and nice catch - Step 2 did not sync with the ./node changes in Step 3. One small thing to tweak for consistency, and then LGTM.

hello-world/README.md Outdated Show resolved Hide resolved
paulyuk
paulyuk previously approved these changes Mar 16, 2022
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

W/o this change the reader might not realize they need to cd into the
'node' dir to see the app.js file that we talk about next.

Also removed some extra whitespace at the end of some lines.

Signed-off-by: Doug Davis <dug@microsoft.com>
@duglin
Copy link
Contributor Author

duglin commented Mar 22, 2022

rebased - should be good to go now.

@msfussell msfussell merged commit 2303dab into dapr:master Mar 24, 2022
@duglin duglin deleted the minor branch March 24, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants