Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new validaters for new quickstarts - pubsub #606

Merged
merged 9 commits into from
Mar 17, 2022
Merged

add new validaters for new quickstarts - pubsub #606

merged 9 commits into from
Mar 17, 2022

Conversation

tanvigour
Copy link
Contributor

Signed-off-by: tanvigour tanvi.gour@gmail.com

Description

Please explain the changes you've made

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #551

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
@tanvigour tanvigour changed the title add new validaters for clean test runs add new validaters for new quickstarts - pubsub Mar 16, 2022
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you for the huge contribution of tests here.

Note I was wondering why C# and Java are not a part of this but @tanvigour and Hal explained the reliability of the test beds for those app types is not there, and will destabilize currently.

@artursouza artursouza merged commit e6e1141 into dapr:feature/new_quickstarts Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants