Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validations for service invocation #607

Merged
merged 14 commits into from
Mar 18, 2022
Merged

Added validations for service invocation #607

merged 14 commits into from
Mar 18, 2022

Conversation

amulyavarote
Copy link
Contributor

@amulyavarote amulyavarote commented Mar 16, 2022 •
edited

Signed-off-by: Amulya Varote amulyavarote@microsoft.com

Description

Please explain the changes you've made

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #551

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Amulya Varote and others added 5 commits March 16, 2022 12:22
Added validations for service invocation
5bd5e33 
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
@amulyavarote
Merge pull request #1 from amulyavarote/service_invo_validations
b980c88 
Added validations for service invocation
Fixed java readme file
ecb628e 
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
@amulyavarote
Merge pull request #2 from amulyavarote/service_invo_validations
5555da7 
Fixed java readme file
@amulyavarote
Merge branch 'dapr:feature/new_quickstarts' into feature/new_quickstarts
43fe2bf
tanvigour
tanvigour approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@tanvigour tanvigour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

paulyuk
paulyuk approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Amulya Varote and others added 9 commits March 17, 2022 14:40
@amulyavarote
Removing csharp validation
987ed4e 
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Added license to yaml files
8070290 
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Changes based on the previous PR merge
34603da 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
test fix
b73f973 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Changed validation
95871a4 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
tests fix trial
af2ec83 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
test fixes for python
f1e487f 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Added seperate workflows to quickstarts
0a6320d 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
@amulyavarote
Removed failed docker link
a8dd479 
Signed-off-by: Amulya Varote <amulyavarote@QTM-SWATHIKIL-1.redmond.corp.microsoft.com>
artursouza
artursouza requested changes Mar 18, 2022
View reviewed changes
Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep it all in a single workflow and separate in the stages within?

@artursouza artursouza merged commit b3b1e2d into dapr:feature/new_quickstarts Mar 18, 2022
@amulyavarote amulyavarote deleted the service_invo_validations branch March 18, 2022 17:45
@amulyavarote amulyavarote mentioned this pull request Apr 12, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artursouza artursouza artursouza approved these changes

@paulyuk paulyuk paulyuk approved these changes

@tanvigour tanvigour tanvigour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amulyavarote @artursouza @paulyuk @tanvigour