-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "slowness" back to Observability tutorial #620
Conversation
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
…de will never be slow enough to return traces results! Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
…ner from GHCR Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
I would still like an RCA why multiplyapp deployment shows as unchanged in kubernetes/kind, but I have at least achieved the two goals of 1) the tests pass and 2) the observability tutorial delivers on its promise of finding slow requests. For these reasons I suggest we take and merge this. |
The 19411 change is simply to avoid the clash between self hosted and K8s if running on the same machine correct? |
Yes exactly. This tutorial starts users in the self hosted mode with zipkin, and then transitions into the kubernetes mode, walking them straight into the clash. Given we're port mapping/forwarding anyway I feel this is the ideal solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updated Kubernetes deploy manifests to pull the "slow" container image for multiply app, and then updated Readme to filter zipkin by slow requests.
Issue reference
#619
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: