-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python pub_sub fastapi example #635
Conversation
@inirudebwoy apologies the review has taken so long. can you please resolve the conflict? |
@yaron2 No worries. I have resolved the conflicts. There seems to be some issue with signature. |
@inirudebwoy Can you please take the recent changes from master and rebase this with master and push the changes? And also, can you please fix DCO as well. |
c2fa222
to
4019009
Compare
@amulyavarote Sure thing. I hope it's fine now. |
Can you please fix the build errors? The changes look good to me. Lets make sure these changes work before merging by seeing the successful validations. |
ca1e26c
to
7a0a2fa
Compare
I really like the way you test documentation 👍my code has failed on something I have not changed. Or is it related?
Best regards
Michał Klich
… On 1 May 2022, at 1:09 AM, Yaron Schneider ***@***.***> wrote:
Assigned #635 to @inirudebwoy.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.
|
I reran the failed workflows. Let's see if it succeeds. |
@amulyavarote I think mac validations are failing regardless of this PR. |
@yaron2 Usually rerunning the tests fixes it. I did it again. The previous PRs build passed. |
I think it's consistent.. |
Distributed Calculator and Bindings are failing inconsistently. |
Do you need my help in solving this? I'm not able to run Github Actions on my account unfortunately. |
@amulyavarote can we merge this PR? |
Yes!! |
I pushed a change. Can you please rebase now? I will merge the PR after the builds succeed. |
Signed-off-by: Michał Klich <michal@klichx.dev>
I have rebased it. |
Signed-off-by: Michał Klich michal@klichx.dev
Description
I have updated FastAPI example attached to
pub_sub
for Python.It had not worked correctly.
Issue reference
Sorry, but there is no issue.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: