Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed docker installation version #649

Merged
merged 9 commits into from
Apr 15, 2022

Conversation

amulyavarote
Copy link
Contributor

@amulyavarote amulyavarote commented Apr 14, 2022

Signed-off-by: Amulya Varote amulyavarote@microsoft.com

Description

Please explain the changes you've made

Changed docker version in workflows to avoid docker installation hanging.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 05163cc into dapr:master Apr 15, 2022
@amulyavarote amulyavarote deleted the docker_version branch April 16, 2022 21:49
amulyavarote added a commit to amulyavarote/quickstarts that referenced this pull request Apr 27, 2022
* Changed docker installation version

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Added virtual box to the minikube

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Reduced memory size

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Reduced memory size

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Updated docker version in all the workflows

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Changed version for tutorials

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Reverted version change

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Changed mac os version back to 10.15

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>

* Reverted macos version back to latest

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants