-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed docker installation version #649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
msfussell
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amulyavarote
added a commit
to amulyavarote/quickstarts
that referenced
this pull request
Apr 27, 2022
* Changed docker installation version Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Added virtual box to the minikube Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Reduced memory size Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Reduced memory size Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Updated docker version in all the workflows Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Changed version for tutorials Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Reverted version change Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Changed mac os version back to 10.15 Signed-off-by: Amulya Varote <amulyavarote@microsoft.com> * Reverted macos version back to latest Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amulya Varote amulyavarote@microsoft.com
Description
Please explain the changes you've made
Changed docker version in workflows to avoid docker installation hanging.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: NA
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: