Added secrets management examples with the workflow #653
Conversation
| echo "DAPR_CLI_VERSION=$CLI_VERSION" >> $GITHUB_ENV | ||
| echo "Found $CLI_VERSION" | ||
| shell: bash | ||
| - name: Set up Dapr CLI - Mac/Linux |
There was a problem hiding this comment.
Will this pull from Docker hub or GHCR by default now? If Docker hub we need a docker login action as seen in other workflows.
| version: v1 | ||
| metadata: | ||
| - name: secretsFile | ||
| value: secrets.json |
There was a problem hiding this comment.
I think this means secrets.json is colocated in the source code / repo folder, and that is an anti pattern. We really need this file in a User or Home subfolder. I understand that is a pain for different operating systems.
There was a problem hiding this comment.
For a Quickstart, having the file versioned and ready is a good experience IMO. Generating the file on demand can be more of a pain to make the Quickstart reproducible.
There was a problem hiding this comment.
I get your point, just it's still very bad practice. Really we should do your suggestion here: dapr/components-contrib#1037
That will take a while, what if we had a script that did a quick version for linux/mac/windows?
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
amulyavarote
force-pushed
the
secrets_management_eg
branch
from
092452b
to
d04806b
Compare
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote amulyavarote@microsoft.com
Description
Please explain the changes you've made
Added secrets management examples with the workflow.
Examples included for Csharp, Python and Javascript
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #652
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: