Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order_pub_sub to orderpubsub #654

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Change order_pub_sub to orderpubsub #654

merged 1 commit into from
Apr 26, 2022

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Apr 20, 2022

Applying the pub/sub component to Kubernetes results in the following error:

The Component "order_pub_sub" is invalid: metadata.name: Invalid value: "order_pub_sub": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

This PR fixes the component name to be compliant with RFC 1123 .

Signed-off-by: yaron2 <schneider.yaron@live.com>
@yaron2 yaron2 merged commit 5bd523f into dapr:master Apr 26, 2022
@yaron2 yaron2 deleted the compfix-1 branch April 26, 2022 23:10
mthmulders pushed a commit to mthmulders/dapr-docs that referenced this pull request Sep 20, 2022
Update docs to match changes made to the demo in: dapr/quickstarts#654

Signed-off-by: Szymon Duchniewicz <szduchniewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants