Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java quickstart examples for secret store building block #670

Merged
merged 2 commits into from
May 13, 2022

Conversation

pravinpushkar
Copy link
Contributor

Signed-off-by: Pravin Pushkar ppushkar@microsoft.com

Description

QuickStart examples for Secret store building block using HTTP client and SDK client

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar changed the title Quickstart example for secret store building block Java quickstart examples for secret store building block May 6, 2022
@amulyavarote
Copy link
Contributor

Can you please add validations to the workflow?

@amulyavarote
Copy link
Contributor

Thanks for this contribution on the Java side.

@pravinpushkar pravinpushkar force-pushed the java_secret_store branch 3 times, most recently from 6784ed6 to 29d2618 Compare May 10, 2022 08:57
@pravinpushkar
Copy link
Contributor Author

Can you please add validations to the workflow?

The validate jobs are failing for macos in maven install, I am trying to resolve this.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@amulyavarote
Copy link
Contributor

Can you please add validations to the workflow?

The validate jobs are failing for macos in maven install, I am trying to resolve this.

Sure! Thanks!

@pravinpushkar
Copy link
Contributor Author

Can you please add validations to the workflow?

The validate jobs are failing for macos in maven install, I am trying to resolve this.

Sure! Thanks!

It is fixed now.

@msfussell msfussell merged commit 2ae022f into dapr:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants