Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java quickstarts auto validate for pubsub, state mgmt and service invo #671

Merged
merged 4 commits into from
May 23, 2022

Conversation

pravinpushkar
Copy link
Contributor

Signed-off-by: Pravin Pushkar ppushkar@microsoft.com

Description

Java quickstarts auto validate changes

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@pravinpushkar pravinpushkar changed the title Java quickstarts auto validate changes Java quickstarts auto validate for pubsub, state mgmt and service invo May 12, 2022
@pravinpushkar pravinpushkar force-pushed the master branch 2 times, most recently from 74573c6 to a8e73ed Compare May 17, 2022 11:18
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@amulyavarote
Copy link
Contributor

@pravinpushkar Can we take a look at docker install version in the workflow? Docker install is getting stuck.

@pravinpushkar
Copy link
Contributor Author

@pravinpushkar Can we take a look at docker install version in the workflow? Docker install is getting stuck.

I will take a look.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar
Copy link
Contributor Author

@khs1994
Copy link

khs1994 commented May 21, 2022

try test on macos-10.12

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@msfussell msfussell merged commit eb69a7c into dapr:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants