Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed docker image prefix addition step #694

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

amulyavarote
Copy link
Contributor

@amulyavarote amulyavarote commented Jun 20, 2022

Signed-off-by: Amulya Varote amulyavarote@microsoft.com

Description

Please explain the changes you've made

Removed docker image prefix addition step in makefile

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@paulyuk
Copy link
Contributor

paulyuk commented Jul 23, 2022

@amulyavarote why are we making this change? What does it solve? thank you

@amulyavarote
Copy link
Contributor Author

@amulyavarote why are we making this change? What does it solve? thank you

We are making this change because we don't need these lines now based on the workflow we have.

Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
@@ -168,8 +168,6 @@ name: Run csharp subscriber
expected_stdout_lines:
- "You're up and running! Both Dapr and your app logs will appear here."
- '== APP == A: Message on A'
- '== APP == B: Message on B'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume we're having problems with all services reporting in on time?

@paulyuk paulyuk merged commit 9fc5d06 into dapr:master Jul 26, 2022
@amulyavarote amulyavarote deleted the removed_docker_images_step branch July 26, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants