Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating uber readme for all quickstarts with Bindings & Secrets content link #698

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Updating uber readme for all quickstarts with Bindings & Secrets content link #698

merged 2 commits into from
Jun 23, 2022

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jun 23, 2022 •
edited

  • added link to new Bindings quickstart
  • tightened up descriptons (remove "Demonstrates .." repetition in descriptions, and better explain the role of the building block in the sample)

Signed-off-by: Paul Yuknewicz paulyuk@microsoft.com

Description

Please explain the changes you've made

Issue reference

follow on to #669
Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@paulyuk
updating readme for all quickstarts:
94d99a3 
- added link to new Bindings quickstart
- tightened up descriptons (remove "Demonstrates repetition", and better explain the role of the building block in the sample)

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk changed the title updating uber readme for all quickstarts Updating uber readme for all quickstarts with Bindings Jun 23, 2022
@paulyuk
Secrets is there too, so updating readme
ccbaec5 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk changed the title Updating uber readme for all quickstarts with Bindings Updating uber readme for all quickstarts with Bindings & Secrets content link Jun 23, 2022
msfussell
msfussell approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 7b202e5 into dapr:master Jun 23, 2022
@yaron2 yaron2 added this to the 1.8 milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

Assignees

@paulyuk paulyuk

Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulyuk @msfussell @yaron2