701: Java quickstarts cleanup: #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused imports - Code style: add space after statements - Removed unused test code - Moved Dapr client creation outside of loops - Update dapr-sdk versions to 1.5 - Added Maven artifact name and description where missing - Aligned Maven artifact names to camel case Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
|
These code changes also require changes in the docs. The corresponding PR in the docs is here docs/pull/2639 |
paulyuk
requested changes
Jul 11, 2022
bindings/java/http/batch/pom.xml
Outdated
| <name>OrderProcessingService</name> | ||
| <description>Demo for Dapr pubsub component</description> | ||
| <name>BatchProcessingService</name> | ||
| <description>Quickstart for Dapr Bingings building block</description> |
There was a problem hiding this comment.
Suggested change
| <description>Quickstart for Dapr Bingings building block</description> | |
| <description>Quickstart for Dapr Bindings building block</description> |
There was a problem hiding this comment.
thanks, this is fixed now. Notice also the related quickstart docs PR in the docs project :)
| "}"); | ||
|
|
||
| return mapper.readValue(json, Orders.class); | ||
| try (InputStream is = getClass().getClassLoader().getResourceAsStream(path)) { |
There was a problem hiding this comment.
removing mock is ok. I agree with this.
| @@ -14,11 +14,11 @@ public class CheckoutServiceApplication { | |||
| public static void main(String[] args) throws InterruptedException{ | |||
| String TOPIC_NAME = "orders"; | |||
| String PUBSUB_NAME = "orderpubsub"; | |||
| DaprClient client = new DaprClientBuilder().build(); | |||
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bilgin Ibryam bibryam@gmail.com
Description
Issue reference
#701
Please reference the issue this PR will close: #[701]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: