Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for bindings db #703

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

sunzhaochang
Copy link
Contributor

@sunzhaochang sunzhaochang commented Jul 12, 2022

Signed-off-by: sunzhaochang zhchsun1992@gmail.com

Description

Fix some errors in README for bindings db.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@youngwookim
Copy link

Overall, Looks good!
A minor nit: change to the orders table should be change to the orders database WDYT?

@sunzhaochang
Copy link
Contributor Author

@youngwookim Thanks for catching that. I will fix it.

Signed-off-by: sunzhaochang <zhchsun1992@gmail.com>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk paulyuk merged commit 95f81e6 into dapr:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants