Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js version to support null coalescing #707

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

halspang
Copy link
Contributor

Description

Several node apps now use the null coalescing operator '??' which
is not supported until node v14+.

Signed-off-by: Hal Spang halspang@microsoft.com

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #706

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Several node apps now use the null coalescing operator '??' which
is not supported until node v14+.

Signed-off-by: Hal Spang <halspang@microsoft.com>
@amulyavarote
Copy link
Contributor

bindings workflow for dotnet is failing. We can merge this PR after the workflow is fixed.

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk paulyuk merged commit 3a8d76d into dapr:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js Version out of date for hello-world
3 participants