Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven dependency incompatible with Java 11 #722

Conversation

thisiskun
Copy link
Contributor

Signed-off-by: Ken Chen chenchaokun@gmail.com

Description

Change the maven dependency version to make demos compatible with Java 11.

Issue reference

close #719

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@amulyavarote
Copy link
Contributor

@thisiskun Can you please pull the latest changes from master and rebase them with your changes?

artursouza
artursouza previously approved these changes Aug 11, 2022
Signed-off-by: Ken Chen <chenchaokun@gmail.com>
@thisiskun
Copy link
Contributor Author

@amulyavarote I just made a rebase, but I am not so familiar with the rebase command, please check if it's ok, thanks.

@amulyavarote
Copy link
Contributor

Changes look good to me!

@amulyavarote amulyavarote merged commit 6f9f92f into dapr:master Aug 19, 2022
@thisiskun thisiskun deleted the fix-maven-dependency-incompatible-with-java11 branch August 20, 2022 02:27
@yaron2 yaron2 added this to the 1.9 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some quickstarts demos incompatible with Java 11
4 participants