Added parallelism to pubsub workflow #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amulyavarote
force-pushed
the
parallel_workflows
branch
from
894864d
to
7d0b7d2
Compare
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
amulyavarote
force-pushed
the
parallel_workflows
branch
from
7d0b7d2
to
e4540b2
Compare
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
4 tasks
paulyuk
requested changes
Aug 27, 2022
.github/workflows/validate_new_quickstarts_secrets_management.yaml
Outdated
Show resolved
Hide resolved
.github/workflows/validate_new_quickstarts_state_management.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
As we have different workflow for each building block. I think there is no sharing of resources. And examples use different port numbers under each building block. |
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
amulyavarote
force-pushed
the
parallel_workflows
branch
from
444a178
to
ccc6a6b
Compare
paulyuk
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Thanks a lot @amulyavarote
These port changes look great.
I do wonder if we should have uniquely named ALL app-ids. Let's try this and watch, just to make sure there's no collision.
LGTM
| @@ -40,6 +41,8 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-10.15] | |||
| quickstart_language: [go, csharp, javascript, python, java] | |||
| @@ -502,8 +502,6 @@ kubectl logs --selector app=python-subscriber -c python-subscriber | |||
| name: Deploy Csharp App | |||
| expected_stdout_lines: | |||
| - "A: Message on A" | |||
| - "B: Message on B" | |||
There was a problem hiding this comment.
These lines are indeed brittle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amulya Varote amulyavarote@microsoft.com
Description
Please explain the changes you've made
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #730
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: