Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme service invocation description #753

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix readme service invocation description #753

merged 1 commit into from
Jan 11, 2023

Conversation

bookinstock
Copy link
Contributor

No description provided.

paulyuk
paulyuk requested changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I don't think I agree with this. Even though this is a "direct HTTP call" and the http protocol is considered synchronous (unlike queue or message based), the client is still done async to be well behaved in web and cloud.

https://github.com/dapr/quickstarts/blob/master/service_invocation/csharp/http/checkout/Program.cs#L18

@paulyuk
Copy link
Contributor

paulyuk commented Jan 11, 2023

Hi @bookinstock - I've reflected on this, spoken to others, and I'm flipping here. This is an improvement and we'll take it. Thank you for the contribution!

@paulyuk paulyuk merged commit 33d1cbc into dapr:master Jan 11, 2023
@artursouza artursouza added this to the 1.10 milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulyuk paulyuk paulyuk approved these changes

@yaron2 yaron2 yaron2 approved these changes

@pravinpushkar pravinpushkar pravinpushkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bookinstock @paulyuk @yaron2 @pravinpushkar @artursouza