Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize dapr client only once and misc fixes #754

Merged
merged 6 commits into from
May 17, 2023

Conversation

mukundansundar
Copy link
Contributor

Signed-off-by: Mukundan Sundararajan 65565396+mukundansundar@users.noreply.github.com

Description

In python DaprClient() was being initialized in the for loop. It can be initialized only once for the whole duration of the quick start.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@mukundansundar mukundansundar marked this pull request as ready for review December 2, 2022 07:33
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@mukundansundar mukundansundar changed the title initialize dapr client only once initialize dapr client only once and misc fixes Dec 2, 2022
pravinpushkar
pravinpushkar previously approved these changes Dec 2, 2022
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let's just make sure it syncs

@paulyuk paulyuk merged commit d7e7f71 into dapr:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants