Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

772, constant retry examples using incorrect maxInterval option #779

Conversation

LordMsz
Copy link
Contributor

@LordMsz LordMsz commented Jan 31, 2023

Signed-off-by: LordMsz Mr.MarekSmolik@gmail.com

Description

Fixed incorrectly used "maxInterval" option in resiliency.yaml files for constant policy retries. This option is not valid for constant policy, only for exponential policy.

Issue reference

#772

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: LordMsz <Mr.MarekSmolik@gmail.com>
@msfussell
Copy link
Member

@LordMsz - Really appreciate you pushing this PR fix

…nt-retry-examples-using-incorrect-maxInterval-option
@artursouza artursouza merged commit 5ac2a30 into dapr:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants