Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial validation and docker build. #783

Merged

Conversation

artursouza
Copy link
Member

Signed-off-by: Artur Souza asouza.pro@gmail.com

Description

Fix tutorial validation and docker build.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: endgame

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@@ -91,7 +87,7 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}
- name: Build docker image
env:
SAMPLE_REGISTRY: ghcr.io/dapr/samples
SAMPLE_REGISTRY: ghcr.io/${{ github.repository_owner }}/samples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to lowercase this or it won't work for people who have mixed case usernames on GitHub like, say, ItalyPaleAle :)

Example: https://github.com/dapr/dapr/blob/3713a058c7c64455ffa8d96d1bc173b7e64f96d2/.github/workflows/dapr.yml#L84-L90

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza force-pushed the fix_build_and_tutorials_validation branch from ed0d670 to 5495f9b Compare February 3, 2023 16:06
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artursouza artursouza merged commit 32901b5 into dapr:master Feb 3, 2023
@artursouza artursouza added this to the 1.10 milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants