Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show insights into the Cloud Events in the Pub/Sub tutorial #784

Merged
merged 13 commits into from
Jun 2, 2023
Merged

Show insights into the Cloud Events in the Pub/Sub tutorial #784

merged 13 commits into from
Jun 2, 2023

Conversation

shivanisinghnitp
Copy link
Contributor

Description

Added commands to see the details of events in the redis stream

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #668

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@msfussell msfussell added this to the 1.11 milestone May 15, 2023
@msfussell msfussell requested a review from paulyuk May 15, 2023 21:51
@rabollin
Copy link
Contributor

@shivanisinghnitp - Please prioritize this issue and address the review comments.

@shivanisinghnitp
Insights on cloud events
fb63aeb 
Signed-off-by: shivanisinghnitp <58537821+shivanisinghnitp@users.noreply.github.com>
@shivanisinghnitp
Copy link
Contributor Author

@msfussell please look into the changes based on your comments. Thank you

shivanisinghnitp and others added 6 commits May 22, 2023 06:04
@shivanisinghnitp
Some minor spacing related changes
85c1338 
Signed-off-by: shivanisinghnitp <58537821+shivanisinghnitp@users.noreply.github.com>
@shivanisinghnitp @msfussell
Update tutorials/pub-sub/README.md
10ce33f 
Some commands were unclear earlier. Changes to provide more clarity on them

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: shivanisinghnitp <58537821+shivanisinghnitp@users.noreply.github.com>
@shivanisinghnitp @msfussell
Update tutorials/pub-sub/README.md
67cd03e 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: shivanisinghnitp <58537821+shivanisinghnitp@users.noreply.github.com>
@shivanisinghnitp @msfussell
Update tutorials/pub-sub/README.md
3e999c5 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: shivanisinghnitp <58537821+shivanisinghnitp@users.noreply.github.com>
@shivanisinghnitp @msfussell
Update tutorials/pub-sub/README.md
505e99a 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: shivanisinghnitp <58537821+shivanisinghnitp@users.noreply.github.com>
@shivanisinghnitp
Minor changes to text
20cec8e 
Signed-off-by: Shivani Singh <shivanisingh.nitp@gmail.com>
Signed-off-by: shivanisinghnitp <58537821+shivanisinghnitp@users.noreply.github.com>
paulyuk
paulyuk previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With suggested changes (let's omit tests, and focus on doc), this LGTM. Thank you much for your contribution!

tutorials/pub-sub/README.md Outdated Show resolved Hide resolved
tutorials/pub-sub/README.md Outdated Show resolved Hide resolved
tutorials/pub-sub/README.md Outdated Show resolved Hide resolved
tutorials/pub-sub/README.md Outdated Show resolved Hide resolved
tutorials/pub-sub/README.md Outdated Show resolved Hide resolved
tutorials/pub-sub/README.md Outdated Show resolved Hide resolved
@paulyuk
Update tutorials/pub-sub/README.md
5f14c6a 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Update tutorials/pub-sub/README.md
7da31c9 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Update tutorials/pub-sub/README.md
a1f2b44 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Update tutorials/pub-sub/README.md
69d6ad6 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Update tutorials/pub-sub/README.md
16c4f99 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Update tutorials/pub-sub/README.md
0c5eb9d 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
paulyuk
paulyuk approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk paulyuk merged commit 4b086fa into dapr:master Jun 2, 2023
1 check passed
@msfussell msfussell mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell left review comments

@paulyuk paulyuk paulyuk approved these changes

Assignees
No one assigned
Labels
area/pubsub
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

Show insights into the Cloud Events in the Pub/Sub tutorial
4 participants
@shivanisinghnitp @rabollin @paulyuk @msfussell