Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Actors .NET Quickstart #804

Merged
merged 46 commits into from
May 22, 2023
Merged

New Actors .NET Quickstart #804

merged 46 commits into from
May 22, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Mar 4, 2023 •
edited by msfussell
Loading

Description

New quickstart for Actors building block. Details are in the proposal.

Issue reference

#775

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Paul Yuknewicz and others added 19 commits February 1, 2023 01:21
Initial checkin of starter app
7eaaea2 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
changing Record to Class given Actors cannot serialize records
0ebfd9e 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Updating to use custom statestore and port 5001
8710e18 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Modernized to 100% minimal API code; no Startup.cs needed.
c8751f5 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Mocked Controller actor and chose better names
085d783 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Fixed ControllerActor activiation
96d03bb 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Readme cleanup
fb7852a 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
removed dead legacy usings/code
568d1aa 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
multitarget inferfaces to .net 6;7
5f92989 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Style linting
eec8993 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
readme improvement
9f27d82 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@marcduiker
new structure of README
406a867
@marcduiker
Rewrite first section to better align with existing quickstarts
ec26ee1
@marcduiker
Add examples of using the client app.
d5ca290
@marcduiker
Align README with new structure
0e275e9
Updated readme for format and simplicity. Todos are done.
14f14c1 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
tweak to readme to make more language independent
4587d89 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
fixing up folder names in readme
a9ae13f 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk
Merge branch 'dapr:master' into feature/actors
4a1c1bf
@paulyuk paulyuk added the do-not-merge Do not merge the PR label Mar 4, 2023
@paulyuk paulyuk requested a review from msfussell March 4, 2023 19:47
@msfussell msfussell added this to the 1.11 milestone May 3, 2023
paulyuk and others added 3 commits May 22, 2023 08:13
@paulyuk
Merge branch 'dapr:master' into feature/actors
41c9201
staging a reminders feature
a3b93d8 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Implemented reminders to clear alarm state after 15 seconds
702bbcd 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk removed the do-not-merge Do not merge the PR label May 22, 2023
@paulyuk @msfussell
Update actors/csharp/sdk/README.md
ec65c5c 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
paulyuk
paulyuk commented May 22, 2023
View reviewed changes
Copy link
Contributor Author

@paulyuk paulyuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All feedback addressed. Docs handled separately in another issue (https://github.com/dapr/docs/pull/3309/files).

@msfussell ready to merge

@paulyuk
Copy link
Contributor Author

paulyuk commented May 22, 2023

@hhunter-ms fyi

Paul Yuknewicz added 4 commits May 22, 2023 11:57
updated expected output in readme with reminder
8cfe12c 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Merge branch 'feature/actors' of github.com:paulyuk/quickstarts into …
ff144fe 
…feature/actors
Updating main quickstarts readme to include Actors
9487308 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Removing In-development label from readme
4a55409 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
updating MD per jgm/pandoc#2117
bc3a760 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
msfussell
msfussell reviewed May 22, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Here are a few minors updates.

actors/csharp/sdk/service/ControllerActor.cs Show resolved Hide resolved
paulyuk and others added 6 commits May 22, 2023 12:32
@paulyuk @msfussell
Update actors/csharp/sdk/README.md
8c77a89 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk @msfussell
Update actors/csharp/sdk/service/SmokeDetectorActor.cs
442909f 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk @msfussell
Update actors/csharp/sdk/service/SmokeDetectorActor.cs
4c22289 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk @msfussell
Update actors/csharp/sdk/README.md
c055b54 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk @msfussell
Update actors/csharp/sdk/service/ControllerActor.cs
c0caecf 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk @msfussell
Update actors/csharp/sdk/service/SmokeDetectorActor.cs
a34f6bb 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Copy link
Contributor Author

paulyuk commented May 22, 2023

@msfussell thanks for tweaks, resolved

@msfussell msfussell merged commit f798f88 into dapr:master May 22, 2023
7 of 13 checks passed
@msfussell msfussell changed the title New Actors Quickstart New Actors .NET Quickstart May 22, 2023
@msfussell msfussell mentioned this pull request May 22, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulyuk @msfussell @marcduiker