Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conribution instructions for quickstart workflow #819

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

ASHIQUEMD
Copy link
Contributor

Description

Adding instructions for contribution to Quickstart github workflow.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #815

Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
pravinpushkar
pravinpushkar previously approved these changes Apr 4, 2023
Copy link
Contributor

@pravinpushkar pravinpushkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

paulyuk
paulyuk previously approved these changes Apr 4, 2023
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Badly needed, thank you!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
@ASHIQUEMD ASHIQUEMD dismissed stale reviews from paulyuk and pravinpushkar via fb46338 April 5, 2023 08:49
@ASHIQUEMD ASHIQUEMD requested a review from paulyuk April 5, 2023 08:50
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk paulyuk merged commit f00f1ea into dapr:master Apr 5, 2023
11 of 13 checks passed
@ASHIQUEMD ASHIQUEMD deleted the workflow-contribution-instruction branch May 29, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create contribution instructions for quickstarts github workflow
3 participants