Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javascript sdk to 3.0.0 #824

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

wralith
Copy link
Contributor

@wralith wralith commented Apr 12, 2023

Description

Update JavaScript codes to use SDK version 3.0.0

Issue reference

#818

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Ayberk Caliskan <wralithdev@gmail.com>
Signed-off-by: Wralith <wralithdev@gmail.com>
Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are some failing tests however (seems flaky at high-level).

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for updating Dapr and also making several quality and style improvements.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Copy link
Contributor

paulyuk commented Jun 2, 2023

Fixing merge conflicts on your behalf..

@paulyuk paulyuk merged commit 0d386f0 into dapr:master Jun 2, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants