Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added header to sample.http #844

Merged
merged 3 commits into from
Jun 3, 2023

Conversation

ehalsey
Copy link
Contributor

@ehalsey ehalsey commented May 24, 2023

Description

Added missing header Content-Type: application/json

Issue reference

Issue #835

Checklist

N/A

Signed-off-by: Eric Halsey ehalseyhb@gmail.com

Signed-off-by: Eric Halsey <ehalseyhb@gmail.com>
@ehalsey
Copy link
Contributor Author

ehalsey commented May 25, 2023

@msfussell noticed you recently re-assigned this to me. Sorry not sure what my next step is. Looks like it is waiting for approval from maintainer.

msfussell
msfussell previously approved these changes May 25, 2023
@msfussell
Copy link
Member

@msfussell noticed you recently re-assigned this to me. Sorry not sure what my next step is. Looks like it is waiting for approval from maintainer.

I was checking the README and the text here also needs updating. See Screenshot. Can you include this update into this PR also?

image

paulyuk
paulyuk previously approved these changes Jun 2, 2023
@paulyuk
Copy link
Contributor

paulyuk commented Jun 2, 2023

@ehalsey looks good. Any chance you can push a quick change to readme with the same updates? Then I will merge.

@paulyuk paulyuk added this to the 1.11 milestone Jun 2, 2023
@ehalsey
Copy link
Contributor Author

ehalsey commented Jun 3, 2023

@ehalsey looks good. Any chance you can push a quick change to readme with the same updates? Then I will merge.

Yes I can do this. Maybe too late but I'll do it anyways.

@ehalsey ehalsey dismissed stale reviews from msfussell and paulyuk via 2cefa46 June 3, 2023 00:58
@ehalsey
Copy link
Contributor Author

ehalsey commented Jun 3, 2023

@paulyuk @msfussell the README.md has been updated. Let me know if you need anything else.

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk
Copy link
Contributor

paulyuk commented Jun 3, 2023

@paulyuk @msfussell the README.md has been updated. Let me know if you need anything else.

Thanks a bunch @ehalsey for this quick change and contribution overall. Never too late. We always expect days to go by since we all have lots going on in our lives. I appreciate. This is in for 1.11!

@paulyuk
Copy link
Contributor

paulyuk commented Jun 3, 2023

The checks failed due to older issues, no need to spend more runners since more recent pass. LGTM!

@paulyuk paulyuk merged commit 05cffa2 into dapr:master Jun 3, 2023
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants