-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added header to sample.http #844
Conversation
Signed-off-by: Eric Halsey <ehalseyhb@gmail.com>
@msfussell noticed you recently re-assigned this to me. Sorry not sure what my next step is. Looks like it is waiting for approval from maintainer. |
I was checking the README and the text here also needs updating. See Screenshot. Can you include this update into this PR also? |
@ehalsey looks good. Any chance you can push a quick change to readme with the same updates? Then I will merge. |
Yes I can do this. Maybe too late but I'll do it anyways. |
Signed-off-by: Eric Halsey <ehalseyhb@gmail.com>
@paulyuk @msfussell the README.md has been updated. Let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a bunch @ehalsey for this quick change and contribution overall. Never too late. We always expect days to go by since we all have lots going on in our lives. I appreciate. This is in for 1.11! |
The checks failed due to older issues, no need to spend more runners since more recent pass. LGTM! |
Description
Added missing header Content-Type: application/json
Issue reference
Issue #835
Checklist
N/A
Signed-off-by: Eric Halsey ehalseyhb@gmail.com