Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Docker error in Build github action #852

Merged
merged 1 commit into from
May 27, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented May 27, 2023

This fixes Build action

Description

Build action is failing because the create docker manifest step actually tries to access Docker container registry first, and that requires a login. To fix we move the Docker login step up before.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

…y won't fail

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk merged commit 426aad3 into dapr:master May 27, 2023
5 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant