Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating python quickstarts to use dapr-dev module #864

Merged
merged 2 commits into from
May 31, 2023
Merged

Updating python quickstarts to use dapr-dev module #864

merged 2 commits into from
May 31, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented May 30, 2023

This is a mechanism to test with "RC" level changes before the official dapr module releases on PyPi.

I have tested locally with make validate

@msfussell @berndverst

Updating python-sdk to use dapr-dev module until new dapr version i…
0972d26 
…s released. unblocks

testing.

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
@paulyuk paulyuk changed the title Updating python-sdk to use dapr-dev module Updating python quickstarts to use dapr-dev module May 30, 2023
@berndverst
Copy link
Member

We should know use RCs / or dev versions in the master branch. I understood that's what we have been doing.

Going forward, let's use a release branch for this (can always reuse the same release branch - that's fine) to temporarily verify the RCs work against quickstarts and prepare the changes. As the last step prior to release we then update the quickstarts release branch to all the final SDK versions and merge this to master.

berndverst
berndverst previously approved these changes May 30, 2023
View reviewed changes
msfussell
msfussell previously approved these changes May 30, 2023
View reviewed changes
Updating dapr-dev module reference with comment saying this is for te…
0ccd05f 
…sting and unsupported

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.guest.corp.microsoft.com>
@paulyuk paulyuk dismissed stale reviews from msfussell and berndverst via 0ccd05f May 30, 2023 19:31
@paulyuk
Copy link
Contributor Author

paulyuk commented May 30, 2023 •
edited

We should know use RCs / or dev versions in the master branch. I understood that's what we have been doing.

Going forward, let's use a release branch for this (can always reuse the same release branch - that's fine) to temporarily verify the RCs work against quickstarts and prepare the changes. As the last step prior to release we then update the quickstarts release branch to all the final SDK versions and merge this to master.

I agree with this approach. It's a bit late for 1.11, so we'll start in 1.12. @msfussell would love your thoughts.

@paulyuk paulyuk merged commit a839430 into dapr:master May 31, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berndverst berndverst berndverst approved these changes

@msfussell msfussell msfussell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulyuk @berndverst @msfussell