Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/config timeout fix #869

Merged
merged 7 commits into from
Jun 3, 2023
Merged

Tests/config timeout fix #869

merged 7 commits into from
Jun 3, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jun 2, 2023 •
edited

Description

  • removed specific check for Unsubscribe in Python validation test
  • also turned of least reliable MacOs matrix tests to speed up iterations. See Test failure - fix MacOs tests #868

Issue reference

See
#868
#859
#860
#798

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Paul Yuknewicz added 2 commits June 1, 2023 23:19
Disabling more Macos-latest tests in matrix. See dapr#868 for long te…
9a8038c 
…rm plan.

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Removing test criteria for Unsubscribe to Config API, which is making…
aaf07a6 
… test flakey

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk added the do-not-merge Do not merge the PR label Jun 2, 2023
Testing for orderid2 and subscriptionid, but not unsubscripe or termi…
16e0d79 
…nate. sleep now can be 15.

Updating Python and C# where we have a need.  Can consider more langs.

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk self-assigned this Jun 2, 2023
@paulyuk paulyuk requested a review from ASHIQUEMD June 2, 2023 07:40
This was referenced Jun 2, 2023
Closed
Open
@paulyuk
Copy link
Contributor Author

paulyuk commented Jun 2, 2023

This fixes all remaining test instabilities for 1.11 release, with exception of golang quickstarts.

For golang, @yaron2 is consulting me how we bring in the commit-based-RC module and avoid the current package not found failure. I made new issue [#870 ] to track.

I recommend we merge this one, and use 870 for the additional golang fix needed. @msfussell pls review.

@paulyuk paulyuk removed the do-not-merge Do not merge the PR label Jun 2, 2023
@paulyuk paulyuk changed the title Draft: Tests/config timeout fix Tests/config timeout fix Jun 2, 2023
@paulyuk paulyuk added the P0 label Jun 2, 2023
@paulyuk paulyuk added this to the 1.11 milestone Jun 2, 2023
artursouza
artursouza previously approved these changes Jun 2, 2023
View reviewed changes
Paul Yuknewicz added 2 commits June 2, 2023 08:26
Merge branch 'master' of github.com:paulyuk/quickstarts into tests/co…
9c5859e 
…nfig-timeout-fix
Fixes dapr#870. RCA is vscode go tools added go.work to monorepo root…
554e45f 
…, and then new workspace package checking started enforcing. Fix is to

delete go.work*

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
msfussell
msfussell previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

disable Macos test for Java.
c2d146f 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
disabling mac on golang test for now
36a1aad 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk merged commit 0b6c42f into dapr:master Jun 3, 2023
6 of 7 checks passed
This was referenced Jun 3, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@artursouza artursouza artursouza left review comments

@ASHIQUEMD ASHIQUEMD Awaiting requested review from ASHIQUEMD

@DeepanshuA DeepanshuA Awaiting requested review from DeepanshuA

Assignees

@paulyuk paulyuk

Labels
P0
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulyuk @artursouza @msfussell