Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Readme's to default to dapr run -f . #874

Merged
merged 13 commits into from
Sep 22, 2023
Merged

Updating Readme's to default to dapr run -f . #874

merged 13 commits into from
Sep 22, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jun 6, 2023

Description

Change readme's to favor and default to multi-app-run behavior using dapr run -f .

Carefully tweak test with 15 second sleep and up to 60second timeout for predictable automated testing.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Updating Invoke readme in C# to favor dapr run -f
71c3511 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
@paulyuk paulyuk added P1 do-not-merge Do not merge the PR labels Jun 6, 2023
@paulyuk paulyuk added this to the 1.11 milestone Jun 6, 2023
@paulyuk paulyuk self-assigned this Jun 6, 2023
msfussell
msfussell reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not remove the steps to show how to start these individually, just put these after the multi-app run. Showing how to use the dapr run command for a single app is still important IMO (the parameters) and needed until the multi-app run command becomes more adopted. If in time multi-app run shows its value, then we can consider having just that, but too early now IMO.

@paulyuk
Copy link
Contributor Author

paulyuk commented Jun 6, 2023

I would not remove the steps to show how to start these individually, just put these after the multi-app run. Showing how to use the dapr run command for a single app is still important IMO (the parameters) and needed until the multi-app run command becomes more adopted. If in time multi-app run shows its value, then we can consider having just that, but too early now IMO.

Ok sounds like a reasonable compromise. I'm not a super big fan of lots of options which themselves create more conceptual overhead, but given where we are, I agree this is a good way to ease into the new model and ensure it's ready or not to be the main thing we show and do.

Adding back single app run steps and tests, but to the end.
3d11e8e 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
paulyuk and others added 4 commits June 13, 2023 22:38
@paulyuk
Merge branch 'dapr:master' into multi-app-run
87169eb
@paulyuk @msfussell
Update service_invocation/csharp/http/README.md
73d817b 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Updated and hardened test
a514f28 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Invoke * and partial PubSub with multi-run files & readmes & tests
5a8078b 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk mentioned this pull request Jun 16, 2023
Closed
Paul Yuknewicz added 3 commits September 4, 2023 11:37
Multi run done for Pubsub C#, Python and Node (http, sdk)
2fb9d15 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Added Pubsub support for Go, Java
3dc9e44 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
updating readmes with correct appid
df6db50 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
@philliphoff
Copy link

I might also note in the READMEs that dapr run -f on Windows requires the upcoming Dapr 1.12.

msfussell
msfussell previously approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms mentioned this pull request Sep 21, 2023
Merged
3 tasks
Updating tests for PubSub and Service invoke to Paas with multiapp run
dbe603d 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk
Merge branch 'master' into multi-app-run
6445c2e 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk removed the do-not-merge Do not merge the PR label Sep 22, 2023
Paul Yuknewicz added 2 commits September 22, 2023 01:24
More fine tuning of pubsub tests (timeouts, step ends)
89dd256 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Fixing Python FastAPI and C# Pubsub tests
98510d6 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
msfussell
msfussell approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@msfussell msfussell merged commit dcd97ee into dapr:master Sep 22, 2023
4 of 7 checks passed
This was referenced Sep 22, 2023
Closed
Closed
Closed
Closed
Closed
@paulyuk paulyuk deleted the multi-app-run branch September 22, 2023 22:34
msfussell added a commit that referenced this pull request Sep 25, 2023
@paulyuk @marcduiker @msfussell
Syncing Release 1.12 with master and multi-run changes (#936)
088b5f6 
* Add holopin.yml config (#923)

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>

* Updating Readme's to default to `dapr run -f .` (#874)

* Updating Invoke readme in C# to favor dapr run -f

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Adding back single app run steps and tests, but to the end.

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Update service_invocation/csharp/http/README.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated and hardened test

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Invoke * and partial PubSub with multi-run files & readmes & tests

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Multi run done for Pubsub C#, Python and Node (http, sdk)

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Added Pubsub support for Go, Java

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* updating readmes with correct appid

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Updating tests for PubSub and Service invoke to Paas with multiapp run

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* More fine tuning of pubsub tests (timeouts, step ends)

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Fixing Python FastAPI and C# Pubsub tests

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

---------

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Patching tests to pass (C# timing, Python uvicorn) (#933)

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

---------

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
msfussell added a commit that referenced this pull request Oct 13, 2023
@paulyuk @cicoyle
@JoshVanL @rabollin @marcduiker @msfussell @pravinpushkar @skyao @mukundansundar
Merging release-1.12 into main branch (#952)
c7f5100 
* update dapr runtime to use v1.12.0-rc.1

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update to latest rc for runtime and cli

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* try sleeping

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* pin redis version

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm sleep

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm deprecated unsubscribe call

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* Update configuration/go/sdk/order-processor/app.go

Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>
Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>

* Statemanagement multiapp run

Signed-off-by: rabollin <rabollin@microsoft.com>

* message sequence

Signed-off-by: rabollin <rabollin@microsoft.com>

* message sequence

Signed-off-by: rabollin <rabollin@microsoft.com>

* Multi-run support for workflow

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Removing component folder from run file to match readme

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* aligning state store names on `statestore`

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Adding multi-app run for python and C#

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* pr comments

Signed-off-by: rabollin <rabollin@microsoft.com>

* pr comments

Signed-off-by: rabollin <rabollin@microsoft.com>

* sleep value increase

Signed-off-by: rabollin <rabollin@microsoft.com>

* sleep seconds increase

Signed-off-by: rabollin <rabollin@microsoft.com>

* Result correction

Signed-off-by: rabollin <rabollin@microsoft.com>

* Result correction

Signed-off-by: rabollin <rabollin@microsoft.com>

* java sdk dapr run output format fixing

Signed-off-by: rabollin <rabollin@microsoft.com>

* Syncing Release 1.12 with master and multi-run changes (#936)

* Add holopin.yml config (#923)

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>

* Updating Readme's to default to `dapr run -f .` (#874)

* Updating Invoke readme in C# to favor dapr run -f

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Adding back single app run steps and tests, but to the end.

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Update service_invocation/csharp/http/README.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated and hardened test

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Invoke * and partial PubSub with multi-run files & readmes & tests

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Multi run done for Pubsub C#, Python and Node (http, sdk)

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Added Pubsub support for Go, Java

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* updating readmes with correct appid

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Updating tests for PubSub and Service invoke to Paas with multiapp run

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* More fine tuning of pubsub tests (timeouts, step ends)

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Fixing Python FastAPI and C# Pubsub tests

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

---------

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Patching tests to pass (C# timing, Python uvicorn) (#933)

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

---------

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Fixing MMD tests with tweaks

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* setting version for kafka (#939)

* fixing version for kafka

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* validate data with some initial values instead of larger

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

---------

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Updating test env to Dapr runtime 1.12 RC4 and CLI RC2

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Update README.md

Fixing typo.  should be singular

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Update README.md

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* add java workflow quickstart

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>

* Updating runtime for tests to RC5

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Fixes port 6003 conflict between Go Pub-sub and Go bindings.  Timing issue

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* add hello-kubernetes multi-app run k8s template

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* address review comments.

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* update cli to rc.4 (#943)

* update cli to rc.3

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update cli to rc.4

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>

* Update CLI to rc4

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Updating .NET SDK to 1.12.*

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Dapr Golang SDK update to v1.9.0-rc-1

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Javascript SDK to 3.1.2

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Release 1.12 (#945)

* Dapr Golang SDK update to v1.9.0-rc-1

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Javascript SDK to 3.1.2

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

---------

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Java SDK update to <version>1.10.0-rc-1</version>

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Updated Java SDK to RC, and donated multi-app-run support too :)

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Updating tests to use dapr/dapr 1.12.0-rc.6

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* sdk version changes

Signed-off-by: rabollin <rabollin@microsoft.com>

* CLI and Runtime version changes

Signed-off-by: rabollin <rabollin@microsoft.com>

* go.sum refresh

Signed-off-by: rabollin <rabollin@microsoft.com>

* Updating with js-sdk 3.2.0

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Signed-off-by: rabollin <rabollin@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Cassandra Coyle <cassie@diagrid.io>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>
Co-authored-by: rabollin <rabollin@microsoft.com>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Sky Ao <aoxiaojian@gmail.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@mukundansundar mukundansundar Awaiting requested review from mukundansundar

Assignees

@paulyuk paulyuk

Labels
P1
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulyuk @philliphoff @msfussell