Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bindings] add direction to component yaml #894

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

hhunter-ms
Copy link
Contributor

Description

Add best practice direction metadata to component yaml files

Issue reference

PR will close: #886 and dapr/docs#3592

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit aeb1017 into dapr:master Aug 2, 2023
12 of 13 checks passed
@paulyuk
Copy link
Contributor

paulyuk commented Sep 22, 2023

Hi @hhunter-ms -- this caused a regression in Tutorials test actions. Here's an example.https://github.com/dapr/quickstarts/actions/runs/5744430856

Could we please research a safer fix?

@msfussell, fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Bindings Quickstart to add "direction" property into the component Yaml files
3 participants