Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java workflow quickstart(clean code) #940

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

skyao
Copy link
Member

@skyao skyao commented Sep 28, 2023

Description

This PR is to replace PR #925 because in PR925 the code included commits from both master and release-1.12 branch.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #903

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
@skyao skyao mentioned this pull request Sep 28, 2023
4 tasks
@paulyuk paulyuk self-requested a review September 28, 2023 15:40
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this very nice contribution.
In a future PR, we may consider adding multi-run-app support, to match the latest quickstart revisions. This is great for now tho.

@paulyuk paulyuk merged commit 16cd6b2 into dapr:release-1.12 Sep 28, 2023
6 of 7 checks passed
@paulyuk
Copy link
Contributor

paulyuk commented Oct 10, 2023

fixes original #898

@yaron2 yaron2 added this to the 1.12 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants