Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests broken by timing change #979

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Feb 9, 2024

Description

Tests now fail in state management CI/CD because of the final dapr stop on the single service. in 1.12.0 the service was still available to stop by the time this step ran. Now, the service is already gone, so stop fails. The fix is to keep the stop in the readme, but remove it from the test workflow which will run it in CI.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Paul Yuknewicz and others added 2 commits February 6, 2024 10:39
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.guest.corp.microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
msfussell
msfussell previously approved these changes Feb 9, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
@paulyuk paulyuk self-assigned this Feb 10, 2024
@paulyuk paulyuk added the P0 label Feb 10, 2024
@paulyuk paulyuk added this to the 1.13 milestone Feb 10, 2024
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
@paulyuk paulyuk merged commit 334b35a into dapr:master Feb 10, 2024
7 checks passed
This was referenced Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants