Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the DAPR bot script addressing this issue #966 #985

Merged
merged 1 commit into from Feb 14, 2024

Conversation

rabollin
Copy link
Contributor

@rabollin rabollin commented Feb 13, 2024

Description

Starting V5 of Github actions, there is a change in the rest end points. github.issues.** has changed to github.rest.issues**; hence dapr bot is not functioning for some of these actions.

Reference: https://github.com/actions/github-script#breaking-changes-in-v5

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #966

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: rabollin <rabollin@microsoft.com>
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulyuk paulyuk added this to the 1.13 milestone Feb 14, 2024
@paulyuk paulyuk added the build label Feb 14, 2024
@paulyuk paulyuk self-requested a review February 14, 2024 09:12
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2. thank you!

@paulyuk paulyuk merged commit df8530c into dapr:release-1.13 Feb 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants