Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clone(stream) method for the RNGs #79

Merged
merged 21 commits into from Apr 15, 2024
Merged

Add clone(stream) method for the RNGs #79

merged 21 commits into from Apr 15, 2024

Conversation

rstub
Copy link
Member

@rstub rstub commented Apr 7, 2024

fixes #64

@rstub
Copy link
Member Author

rstub commented Apr 9, 2024 •
edited

One difficulty is that pcg64 behaves differently whether one uses seed() and set_stream() separately or in one go via seed(seed, stream), c.f. imneme/pcg-cpp#91. It might make sense to always use the separate calls.

Also, requiring C++14 just for std::make_unique feels excessive. Maybe just use the one from boost/smart_ptr/make_unique.hpp?

@rstub rstub mentioned this pull request Apr 12, 2024
Open
@rstub rstub merged commit 6819b9a into main Apr 15, 2024
9 checks passed
@rstub rstub mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usability enhancements for external package authors
1 participant
@rstub