Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save the certificates outside the node module. #8

Closed
daquinoaldo opened this issue Mar 25, 2019 · 0 comments · Fixed by #13
Closed

Save the certificates outside the node module. #8

daquinoaldo opened this issue Mar 25, 2019 · 0 comments · Fixed by #13
Assignees
@daquinoaldo
Labels
good first issue Good for newcomers

Comments

@daquinoaldo
Copy link
Owner

Moving the certificate path to a fixed path, e.g. ~/.https-localhost, will prevent the script to generate a new certificate every time the module is updated.
At the moment, just running npm install will reinstall the module generating again the certificate.

A good path can be:

  • {APPDATA}\https-localhost on Windows
  • ~/.https-localhost on linux
  • ~/Library/Application Support/.https-localhost on darwin

or something similar.
@daquinoaldo daquinoaldo mentioned this issue Mar 25, 2019
Merged
10 tasks
@daquinoaldo daquinoaldo added the good first issue Good for newcomers label Mar 25, 2019
This was referenced Apr 18, 2019
Closed
Closed
@daquinoaldo daquinoaldo added this to the v4.1 milestone Apr 18, 2019
@daquinoaldo daquinoaldo self-assigned this Apr 18, 2019
daquinoaldo added a commit that referenced this issue Apr 23, 2019
@daquinoaldo
Implement #8 and #10: certificates in AppData at firts run.
05e7651 
This prevent the script to generate a new certificate every time
the module is updated.
`certs.js` manages the certificates: creation and deletion, and
provides them to index.js.
An uninstall script is added, it deletes the folder at uninstall
time.

makes problems, generate the certificates at first run.
If the index.js won't find the certificates,
certs.js will generate them.

Some edits in README accordingly to changes.
Add also a link on README to CONTRIBUTING.

Upgrade to v4.1.0 in package.json.
Upgrade of dependencies.
@daquinoaldo daquinoaldo mentioned this issue Apr 23, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daquinoaldo daquinoaldo

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Develop 4.1.0 daquinoaldo/https-localhost
1 participant
@daquinoaldo