Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 mkcert on ubuntu (and my script on MacOS) #2

Merged
merged 6 commits into from
Jan 25, 2019
Merged

Conversation

daquinoaldo
Copy link
Owner

@daquinoaldo daquinoaldo commented Jan 25, 2019

PR Details

Automatically run a postinstall script that trust the generated certificate on MacOS and Ubuntu.

Description

The script uses openssl on MacOS and adds the CA certificate to the Mac trust store.
On Ubuntu uses the mkcert tool.

Motivation and Context

It really helps in automating the process for users. Now in the two most popular OS there is no need for an additional user interaction.

How Has This Been Tested

It is not tested automatically, but has been tested on Ubuntu 18.04 LTS and MacOS Mojave.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. Is too expensive to test it automatically.
  • All new and existing tests passed.

daquinoaldo and others added 6 commits January 25, 2019 10:37
Updates the version number to 2.0.0 since now the postinstall script automatically the certificate.  
Now in most cases the developer has only to install the package without additional steps.
@coveralls
Copy link

coveralls commented Jan 25, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 8ff74bb on mkcert into b22b3e0 on master.

@daquinoaldo daquinoaldo merged commit 9f98a6d into master Jan 25, 2019
@daquinoaldo daquinoaldo deleted the mkcert branch January 25, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants