Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix usernames with spaces problem on windows #33

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

andrecarlucci
Copy link
Contributor

Pull Request Details

Related Issue

#32

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation or my changes don't require it.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes (or the existing one were enough).
  • All new and existing tests passed.

@daquinoaldo
Copy link
Owner

Thank you for your cooperation!
I've fixed the linting errors and cleaned up a bit the code. I've pushed all the edits in your fork.
Before I merge the PR, can you please confirm that it still working on Windows with spaces?

Refer: fixes #33

@aliyss
Copy link

aliyss commented Oct 26, 2019

Can confirm it works.

@daquinoaldo daquinoaldo merged commit cd8c8e5 into daquinoaldo:master Oct 26, 2019
@daquinoaldo
Copy link
Owner

Thank you very much for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants